Skip to content

cleanup: Fix parameter naming case inconsistency in RestRequestExtension.cs#1986

Merged
alexeyzimarev merged 1 commit into
restsharp:devfrom
ztl8702:patch-1
Jan 8, 2023
Merged

cleanup: Fix parameter naming case inconsistency in RestRequestExtension.cs#1986
alexeyzimarev merged 1 commit into
restsharp:devfrom
ztl8702:patch-1

Conversation

@ztl8702

@ztl8702 ztl8702 commented Dec 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Might be breaking because we are changing a named argument. Existing call sites that uses Named argument might fail to compile.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dnfadmin

dnfadmin commented Dec 18, 2022 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@ztl8702 ztl8702 changed the title Fix argument case inconsistency in RestRequestExtension.cs Fix parameter case inconsistency in RestRequestExtension.cs Dec 18, 2022
@ztl8702 ztl8702 changed the title Fix parameter case inconsistency in RestRequestExtension.cs Fix parameter naming case inconsistency in RestRequestExtension.cs Dec 18, 2022
@ztl8702 ztl8702 changed the title Fix parameter naming case inconsistency in RestRequestExtension.cs cleanup: Fix parameter naming case inconsistency in RestRequestExtension.cs Dec 23, 2022
@alexeyzimarev alexeyzimarev merged commit ed0bd11 into restsharp:dev Jan 8, 2023
@ztl8702 ztl8702 deleted the patch-1 branch January 9, 2023 00:44
@ztl8702

ztl8702 commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

thanks

@ztl8702

ztl8702 commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

Lol I have a bad habit of not writing commit messages well.
image

Was assuming the maintainer would squash + modify commit message.

@alexeyzimarev

alexeyzimarev commented Jan 9, 2023

Copy link
Copy Markdown
Member

Yeah, I should change the default.

@dependabot dependabot Bot mentioned this pull request Aug 12, 2025
Closed
This was referenced Aug 20, 2025
Open
Closed
@dependabot dependabot Bot mentioned this pull request Sep 6, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Oct 21, 2025
Open
This was referenced Nov 3, 2025
Closed
Closed
This was referenced Dec 1, 2025
Closed
Closed
This was referenced Jan 13, 2026
Open
Closed
Open
@dependabot dependabot Bot mentioned this pull request Feb 5, 2026
Open
@dependabot dependabot Bot mentioned this pull request Feb 25, 2026
Open
This was referenced Mar 6, 2026
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Mar 14, 2026
Open
@dependabot dependabot Bot mentioned this pull request Mar 28, 2026
Open
This was referenced Apr 14, 2026
Open
Open
Open
@dependabot dependabot Bot mentioned this pull request Apr 30, 2026
Closed
@dependabot dependabot Bot mentioned this pull request May 22, 2026
Open
@dependabot dependabot Bot mentioned this pull request Jun 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ztl8702 @dnfadmin @alexeyzimarev